chore: add blas and extended keywords to nancount packages in blas/ext/base#12120
Merged
Conversation
The `keywords` array previously omitted `blas` and `extended`, both of which appear in 28/28 sibling `nan*` packages in `blas/ext/base` (e.g. `dnansum`, `dnannsum`, `dnanasum`). Insert them at index 6 to match the sibling pattern (after `math`, before the operation-specific keyword).
The `keywords` array previously omitted `blas` and `extended`, both of which appear in 28/28 sibling `nan*` packages in `blas/ext/base` (e.g. `snansum`, `snansumkbn`, `snansumpw`). Insert them at index 6 to match the sibling pattern (after `math`, before the operation-specific keyword).
The `keywords` array previously omitted `blas` and `extended`, both of which appear in 28/28 sibling `nan*` packages in `blas/ext/base` (e.g. `gnansum`, `gnansumkbn`, `gnannsum`). Insert them at index 6 to match the sibling pattern (after `math`, before the operation-specific keyword).
The `keywords` array previously omitted `blas` and `extended`, both of which appear in 28/28 sibling `nan*` packages in `blas/ext/base` (e.g. `dnansum`, `dnannsum`, `dnanasum`). Insert them at index 6 to match the sibling pattern (after `math`, before the operation-specific keyword).
stdlib-bot
added
the
BLAS
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
blasandextendedkeywords to thekeywordsarray inpackage.jsonfor fournancountpackages in@stdlib/blas/ext/base. Each keyword is inserted at index 6 (aftermath) to match the position used by all 28 siblingnan*packages in the same namespace.Namespace summary
@stdlib/blas/ext/baseos,engines,directories,license, README section ordering (Usage/Notes/Examples), file tree (README.md,package.json,lib/index.js,lib/main.js,lib/ndarray.js,docs/repl.txt,docs/types/index.d.ts,docs/types/test.ts,examples/index.js,test/test.js,test/test.ndarray.js,benchmark/benchmark.js,benchmark/benchmark.ndarray.js), and thestdlib/blas/extended/strided/array/math/mathematics/stdmathkeywords.browserfield (71%),gypfilefield (71%),__stdlib__value shape ({}53.5% vs{"wasm": false}36% vs missing 10.5%), full README heading sequence (no single sequence reaches 75%).Per outlier package
blas/ext/base/dnancountAdds the missing
blasandextendedkeywords topackage.json. Operates on a double-precision (Float64) strided array, matching siblingsdnansum,dnannsum, anddnanasum. Theblaskeyword is present in 196/200 (98%) of sibling packages andextendedin 176/200 (88%, 100% within thenan*family).blas/ext/base/snancountAdds the missing
blasandextendedkeywords topackage.json. Operates on a single-precision (Float32) strided array, matching siblingssnansum,snansumkbn, andsnansumpw. Theblaskeyword is present in 196/200 (98%) of sibling packages andextendedin 176/200 (88%, 100% within thenan*family).blas/ext/base/gnancountAdds the missing
blasandextendedkeywords topackage.json. Provides the generic counterpart for arbitrary strided arrays, matching siblingsgnansum,gnansumkbn, andgnannsum. Theblaskeyword is present in 196/200 (98%) of sibling packages andextendedin 176/200 (88%, 100% within thenan*family).blas/ext/base/znancountAdds the missing
blasandextendedkeywords topackage.json. Operates on a double-precision complex (Complex128) strided array, matching siblingsdnannsumanddnanasum; added recently in PR #11514 (April 2026). Theblaskeyword is present in 196/200 (98%) of sibling packages andextendedin 176/200 (88%, 100% within thenan*family).Related Issues
This pull request has the following related issues:
Questions
No.
Other
Validation
Each correction was filtered through:
package.jsonshape, README section list, manifest shape, test/benchmark/example file naming).nancountpackage is a BLAS-extended strided-array operation with the same native-build layout (gypfile,src/,include/,manifest.json) as thenan*sumsiblings — no semantic reason to omit the keywords.tools/or_tools/depends on the keyword list. Confirmed both new values satisfy thekeywordslint regex defined in_tools/package-json/schema/lib/schema.jsonand do not duplicate existing entries.math) is uniform acrossdnansum,gnansum,snansum,dnannsum,dnanasum.Deliberately excluded
benchmark/benchmark.jsdrift. 23 packages lack the canonicalbenchmark.js. All 23 are sort variants (dsort*,gsort*,ssort*) carrying scenario-specific benchmark suites (benchmark.unsorted_random.js,benchmark.sorted_random.js, etc.); the deviation reflects the algorithmic need to benchmark across input distributions and is intentional.__stdlib__field absence. 21 packages (the*index-of*family plusndarrayandwasm) lack a top-level__stdlib__field. Within the 179 packages that do carry it, the value is split between{}(60%) and{"wasm": false}(40%) with no clear correlation togypfile, so there is no unambiguous value to apply.math/mathematics/stdmathkeywords. 20 packages omit these (the*index-of*family plusgjoin-between). These are search and string operations rather than mathematical operations; the omission is consistent with the keyword's semantic meaning.docs/repl.txt,lib/main.js,lib/ndarray.js,test/test.ndarray.jsabsences. Missing only fromndarrayandwasm, which are architectural meta-packages re-exporting variants and legitimately differ.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by an automated cross-package API drift detection routine running under Claude Code. The routine extracts structural features from every package in a randomly selected stdlib namespace, identifies the majority pattern per feature, and proposes mechanical corrections to outliers. Three independent validation agents reviewed the proposed change for semantic appropriateness, downstream dependencies, and structural correctness before any file was modified. All edits and commit messages in this PR were generated by the routine; a maintainer should review before promoting from draft.
@stdlib-js/reviewers
Generated by Claude Code